Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] base_partner_sequence: Migration to 18.0 #1863

Merged
merged 70 commits into from
Oct 25, 2024

Conversation

Kimkhoi3010
Copy link

@Kimkhoi3010 Kimkhoi3010 commented Oct 14, 2024

It found only 2 commits to port:

2 were ignored, I added them to blacklist: Kimkhoi3010@a67e126

Thomas Rehn and others added 30 commits October 14, 2024 11:00
…RP v7.0

* Conventions
* implement 'copy' method, fix translation
* change the scope of sequences to customers and suppliers
Because it is set to readonly conditionally on the view.
Setting the field to readonly prevents users to import it with csv files.
Currently translated at 100.0% (2 of 2 strings)

Translation: partner-contact-11.0/partner-contact-11.0-base_partner_sequence
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-11-0/partner-contact-11-0-base_partner_sequence/nl/
Bump module version to 12.0.1.0.0

Use README by fragment system

Remove copyrights

Update website

Add development_status
Currently translated at 100.0% (2 of 2 strings)

Translation: partner-contact-12.0/partner-contact-12.0-base_partner_sequence
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-base_partner_sequence/gl/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: partner-contact-12.0/partner-contact-12.0-base_partner_sequence
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-base_partner_sequence/
Currently translated at 100.0% (2 of 2 strings)

Translation: partner-contact-12.0/partner-contact-12.0-base_partner_sequence
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-base_partner_sequence/pt_BR/
Currently translated at 100.0% (2 of 2 strings)

Translation: partner-contact-12.0/partner-contact-12.0-base_partner_sequence
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-base_partner_sequence/hr/
@Kimkhoi3010 Kimkhoi3010 changed the title [18.0][MIG] base_partner_sequence: MIgration to 18.0 [18.0][MIG] base_partner_sequence: Migration to 18.0 Oct 14, 2024
@Kimkhoi3010 Kimkhoi3010 mentioned this pull request Oct 16, 2024
45 tasks
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor remarks

super().setUp()

self.res_partner = self.env["res.partner"]
self.partner = self.res_partner.create(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it really needed to create a partner for every test?

import odoo.tests.common as common


class TestBasePartnerSequence(common.TransactionCase):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend using from odoo.addons.base.tests.common import BaseCommon

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@simahawk
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-1863-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit a438219 into OCA:18.0 Oct 25, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e334174. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.