-
-
Notifications
You must be signed in to change notification settings - Fork 851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] base_partner_sequence: Migration to 18.0 #1863
[18.0][MIG] base_partner_sequence: Migration to 18.0 #1863
Conversation
…RP v7.0 * Conventions * implement 'copy' method, fix translation * change the scope of sequences to customers and suppliers
Because it is set to readonly conditionally on the view. Setting the field to readonly prevents users to import it with csv files.
Currently translated at 100.0% (2 of 2 strings) Translation: partner-contact-11.0/partner-contact-11.0-base_partner_sequence Translate-URL: https://translation.odoo-community.org/projects/partner-contact-11-0/partner-contact-11-0-base_partner_sequence/nl/
Bump module version to 12.0.1.0.0 Use README by fragment system Remove copyrights Update website Add development_status
Currently translated at 100.0% (2 of 2 strings) Translation: partner-contact-12.0/partner-contact-12.0-base_partner_sequence Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-base_partner_sequence/gl/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: partner-contact-12.0/partner-contact-12.0-base_partner_sequence Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-base_partner_sequence/
Currently translated at 100.0% (2 of 2 strings) Translation: partner-contact-12.0/partner-contact-12.0-base_partner_sequence Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-base_partner_sequence/pt_BR/
Currently translated at 100.0% (2 of 2 strings) Translation: partner-contact-12.0/partner-contact-12.0-base_partner_sequence Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-base_partner_sequence/hr/
Currently translated at 100.0% (2 of 2 strings) Translation: partner-contact-17.0/partner-contact-17.0-base_partner_sequence Translate-URL: https://translation.odoo-community.org/projects/partner-contact-17-0/partner-contact-17-0-base_partner_sequence/sv/
Currently translated at 100.0% (2 of 2 strings) Translation: partner-contact-17.0/partner-contact-17.0-base_partner_sequence Translate-URL: https://translation.odoo-community.org/projects/partner-contact-17-0/partner-contact-17-0-base_partner_sequence/de/
61c082a
to
986e61a
Compare
3c13750
to
932ebef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor remarks
super().setUp() | ||
|
||
self.res_partner = self.env["res.partner"] | ||
self.partner = self.res_partner.create( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it really needed to create a partner for every test?
import odoo.tests.common as common | ||
|
||
|
||
class TestBasePartnerSequence(common.TransactionCase): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd recommend using from odoo.addons.base.tests.common import BaseCommon
This PR has the |
932ebef
to
3aad374
Compare
3aad374
to
0a600b0
Compare
/ocabot merge nobump |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at e334174. Thanks a lot for contributing to OCA. ❤️ |
It found only 2 commits to port:
2 were ignored, I added them to blacklist: Kimkhoi3010@a67e126